feat: do not create device messages for IMAP authentication errors - #8629
Open
link2xt wants to merge 1 commit into
Open
feat: do not create device messages for IMAP authentication errors#8629link2xt wants to merge 1 commit into
link2xt wants to merge 1 commit into
Conversation
link2xt
force-pushed
the
link2xt/no-cannot-login-device-message
branch
2 times, most recently
from
August 24, 2026 18:32
6c72378 to
2a9b07f
Compare
link2xt
commented
Aug 24, 2026
| break | ||
| # Password is wrong so it definitely has to say something about "password" | ||
| assert "password" in ev.data2 | ||
| # Password is wrong so the error should be about authentication |
Collaborator
Author
There was a problem hiding this comment.
The test is not testing the message anymore, in a way it is a test for #8589 (it is theoretically flaky otherwise)
link2xt
marked this pull request as ready for review
August 24, 2026 18:51
hpk42
approved these changes
Aug 24, 2026
Comment on lines
+399
to
+400
| warn!(context, "IMAP failed to login as {}: {err:#}.", lp.user); | ||
| first_error.get_or_insert(err); |
Contributor
There was a problem hiding this comment.
would be nice to add IMAP failed to login as {imap_user} also to the error both logged and shown to the user.
Authentication failures may happen because of internal server errors. Device message saying "Please check if the email address and the password are correct" was written for classic email setups when the user knows the password. For users of chatmail relays this message is not actionable, but still appears when relay fails to check the password.
link2xt
force-pushed
the
link2xt/no-cannot-login-device-message
branch
from
August 25, 2026 12:55
2a9b07f to
c6e321e
Compare
hpk42
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Authentication failures may happen because of internal server errors. Device message saying "Please check if the email address and the password are correct" was written for classic email setups when the user knows the password. For users of chatmail relays this message is not actionable, but still appears when relay fails to check the password.
Closes #8614 if merged.
#8589 (preferring login errors over connection errors) still makes sense even if device message is deleted as it is important for the error during configuration.